Skip to content

[Release] Milestone M253 #1831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 13, 2025
Merged

[Release] Milestone M253 #1831

merged 4 commits into from
Feb 13, 2025

Conversation

mjcheetham
Copy link
Member

@mjcheetham mjcheetham commented Feb 13, 2025

tyrielv and others added 4 commits January 13, 2025 14:32
On Windows, if the current user is elevated then any directories
created will be owned by the Administrators group. This can cause
problems later on in non-elevated contexts due to git's "dubious
ownership" check. Git for Windows does not currently consider a
non-elevated admin to be the owner of a directory owned by the
Administrators group, though a fix is in progress in the microsoft fork
of git. Libgit2(sharp) also does not have this fix. Also, the GVFS
service which automounts repositories runs under the SYSTEM account,
which would still fail the check even if that fix were in place.

This commit changes the ownership of the .git directory and the working
directory to the current user when cloning.
Remove some of the unused methods left behind after the auto upgrader
was shut down. Also remove the no longer needed dependencies.

Signed-off-by: Matthew John Cheetham <mjcheetham@outlook.com>
Fix ownership when cloning elevated
Remove old unused upgrader methods and dependencies
@mjcheetham mjcheetham requested a review from dscho February 13, 2025 11:18
Copy link
Member

@dscho dscho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@mjcheetham mjcheetham merged commit 2b6bf5d into releases/shipped Feb 13, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants